-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide keyringName configuration to OIDC CredentialsProvider lookup #41293
Provide keyringName configuration to OIDC CredentialsProvider lookup #41293
Conversation
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
Thanks @ryandens, LGTM, can you please rebase to pick up the latest updates, like a Maven version bump to 3.9.8 ? |
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
...ons/oidc-client/deployment/src/test/resources/application-oidc-client-credentials.properties
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
extensions/oidc/deployment/src/test/resources/application-dev-mode.properties
Outdated
Show resolved
Hide resolved
4da9545
to
e2b829e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thank you @sberyozkin! I believe I incorporated all your suggestions, I appreciate the help! |
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
Hi @ryandens A few more tiny suggestions are proposed and it will be ready to go, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can merge once a few more minor doc updates are applied
Co-authored-by: Sergey Beryozkin <[email protected]>
5eb96a5
to
114fd29
Compare
Status for workflow
|
Status for workflow
|
Fixes #41265
CredentialsProviderFinder.find(String)
CredentialsProvider
test implementationMap.get(String)
call on this line would returnnull
because the extension expects the map key to be the configured value forquarkus.oidc.credentials.client-secret.provider.key
. Instead, we verify this functionality by only returning the stubbed secret in theMap
if the keyring name matches our expectations. I think this is desirable as it more maps to how a production-likeCredentialsProvider
implementation would work.OidcCommonUtils
logic to use the configuredkeyringName
, ornull
to look up the OIDC client secret from theCredentialsProvider
, as suggested by @sberyozkin in Quarkus OIDC CredenitalsProvider does not follow conventions of allowing a separate "bean name" and "keyring name" #41265. I wasn't sure if we should instead access this optional value by wrapping the codeblock in aOptional.isPresent
check, like we do for the provider key config item, but happy to follow the suggestions of the Quarkus team.CredentialsProvider
Let me know if there's anything else I can do!