-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observability Dev UI Card and Log Console #41281
Conversation
/cc @cescoffier (devui), @phillip-kruger (devui) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hold until #41244 is merged because it will change the property names being used here.
@brunobat I just pre-emptively updated the PR to use the two new property names for |
Excellent. Will make my best to make it available today. |
This comment has been minimized.
This comment has been minimized.
Just a question for now, what do we do with these DevUI cards, when we add / have more then just LGTM? |
Up to you! We can create the Card as "LGTM" instead of "Observability" etc. We can create many cards or 1 single card with many values. |
Would you prefer I rename this card "LGTM" ? |
@alesj check this out. @phillip-kruger it won't let me rename the Card Title it looks like it always uses the extension name? So if one extension were to produce many cards they would all have the same name I think? |
This comment has been minimized.
This comment has been minimized.
Every extension get's one card. (Else we might have too many cards). You can create multiple pages (sub menus in the maxi view of a card) |
Thanks @phillip-kruger that makes sense. |
This comment has been minimized.
This comment has been minimized.
@brunobat i merged your changes from your recently accepted PR but it won't let me squash them now? |
You should have rebased... |
I made the mistake of fixing a merge conflict in the GitHub editor and that does a merge instead of rebase |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fd36722
to
cb22bd8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
@brunobat can we get this one in? |
soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a minor thing.
Tried the card and looks great.
extensions/observability-devservices/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
extensions/observability-devservices/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
extensions/observability-devservices/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
3f29c19
to
ef8d3fc
Compare
OK resolved all comments |
Status for workflow
|
Status for workflow
|
Fix #41241
Adds DEVUI card and Console logger for the LGTM in the Dev UI.
Card
Log console: