Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observability Dev UI Card and Log Console #41281

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

melloware
Copy link
Contributor

Fix #41241

Adds DEVUI card and Console logger for the LGTM in the Dev UI.

Card

image

Log console:

image

Copy link

quarkus-bot bot commented Jun 18, 2024

/cc @cescoffier (devui), @phillip-kruger (devui)

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold until #41244 is merged because it will change the property names being used here.

@melloware
Copy link
Contributor Author

@brunobat I just pre-emptively updated the PR to use the two new property names for grafana.endpoint and otel-collector.url

@brunobat
Copy link
Contributor

Excellent. Will make my best to make it available today.

This comment has been minimized.

@alesj
Copy link
Contributor

alesj commented Jun 18, 2024

Just a question for now, what do we do with these DevUI cards, when we add / have more then just LGTM?
One for each, or a joined card ... ?

@melloware
Copy link
Contributor Author

melloware commented Jun 18, 2024

Up to you! We can create the Card as "LGTM" instead of "Observability" etc.

We can create many cards or 1 single card with many values.

@melloware
Copy link
Contributor Author

Would you prefer I rename this card "LGTM" ?

@melloware
Copy link
Contributor Author

@alesj check this out. @phillip-kruger it won't let me rename the Card Title it looks like it always uses the extension name? So if one extension were to produce many cards they would all have the same name I think?

image

This comment has been minimized.

@phillip-kruger
Copy link
Member

Every extension get's one card. (Else we might have too many cards). You can create multiple pages (sub menus in the maxi view of a card)

@melloware
Copy link
Contributor Author

Thanks @phillip-kruger that makes sense.

This comment has been minimized.

@melloware
Copy link
Contributor Author

@brunobat i merged your changes from your recently accepted PR but it won't let me squash them now?

@brunobat
Copy link
Contributor

You should have rebased...

@melloware
Copy link
Contributor Author

I made the mistake of fixing a merge conflict in the GitHub editor and that does a merge instead of rebase

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation area/tracing labels Jul 14, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Sep 13, 2024

🙈 The PR is closed and the preview is expired.

@geoand
Copy link
Contributor

geoand commented Sep 16, 2024

@brunobat can we get this one in?

@brunobat
Copy link
Contributor

soon

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a minor thing.
Tried the card and looks great.

@melloware
Copy link
Contributor Author

OK resolved all comments

Copy link

quarkus-bot bot commented Sep 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ef8d3fc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 16, 2024
Copy link

quarkus-bot bot commented Sep 16, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ef8d3fc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand added triage/backport-3.15 and removed area/documentation area/core area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review labels Sep 16, 2024
@geoand geoand merged commit cbb7331 into quarkusio:main Sep 16, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 16, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 16, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 16, 2024
@melloware melloware deleted the lgtm-41241 branch September 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

LGTM extension should have a DevUI Card
6 participants