Introduce finer version control for codestarts and use it #41202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/codestarts
area/devtools
ia3andy
force-pushed
the
fix-compat-codestarts-and-new-version-check
branch
4 times, most recently
from
a9b0a74 to
2e448e6
Compare
|
cc @galderz |
ia3andy
changed the title
|
If we see this version |
aloubyansky
approved these changes
Jun 14, 2024
ia3andy
force-pushed
the
fix-compat-codestarts-and-new-version-check
branch
from
2e448e6 to
16d9c88
Compare
|
I switched to Jackson Version instead of the Java Runtime one, because the Java one is not working with 1.0 |
aloubyansky
previously requested changes
Jun 14, 2024
@aloubyansky we can always change later, this needs no dependency and all the tests are passing fine I know Maven has a better one but it wasn't in there.. |
This comment has been minimized.
This comment has been minimized.
gastaldi
reviewed
Jun 15, 2024
...starts/src/main/java/io/quarkus/devtools/codestarts/core/reader/QuteCodestartFileReader.java
Outdated
Show resolved
Hide resolved
maxandersen
reviewed
Jun 16, 2024
ia3andy
force-pushed
the
fix-compat-codestarts-and-new-version-check
branch
from
16d9c88 to
889daa4
Compare
This comment has been minimized.
This comment has been minimized.
|
@aloubyansky could you merge this? |
aloubyansky
reviewed
Jun 17, 2024
|
|
||
| final class QuteCodestartFileReader implements CodestartFileReader { | ||
|
|
||
| private static final String TPL_QUTE_FLAG = ".tpl.qute"; | ||
| private static final String ENTRY_QUTE_FLAG = ".entry.qute"; | ||
| public static final String INCLUDE_QUTE_FLAG = ".include.qute"; | ||
| public static final String SKIP_TAG = "<SKIP>"; | ||
| private static final Pattern VERSION_PATTERN = Pattern.compile("^(\\d+)(\\.(\\d+))?(\\.(\\d+))?.*"); |
There was a problem hiding this comment.
I guess we don't need this constant anymore and splitVersion(...)?
There was a problem hiding this comment.
right, duuuuuuhhhh another CI run 😬
ia3andy
force-pushed
the
fix-compat-codestarts-and-new-version-check
branch
2 times, most recently
from
834b192 to
76bbdd5
Compare
aloubyansky
approved these changes
Jun 17, 2024
This comment has been minimized.
This comment has been minimized.
ia3andy
force-pushed
the
fix-compat-codestarts-and-new-version-check
branch
from
76bbdd5 to
f4ab373
Compare
ia3andy
force-pushed
the
fix-compat-codestarts-and-new-version-check
branch
from
f4ab373 to
4ff600c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes project generation incompatibility issues introduced by #36826