-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker-build fails to detect podman #41100
Docker-build fails to detect podman #41100
Conversation
8e20b6e
to
b6a794f
Compare
This comment has been minimized.
This comment has been minimized.
749529a
to
f909acb
Compare
FYI this is an addition to #40729, so it'll have to land wherever that lands. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the reported issue, I would add a warning when the docker extension is used and fallback on podman. Thus we inform the user that using the specific podman extension is better.
Now there are teams where some members use docker and some podman. In this case what happens if we use both extensions?
If they don't care about doing anything podman-specific (like building multi-arch images) then they can continue doing what they are doing today. If they want to do things which deviate from common functionality (like building multi-arch images) then they would need both extensions & to configure both extensions, and then use |
9f043b1
to
49357b6
Compare
@cescoffier this is done. I've rebased my commits into a single commit. |
Not sure what's going on but CI looks stuck on this one. I'll see what I can do. |
49357b6
to
b90b893
Compare
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/smallrye-reactive-messaging-kafka/deployment
✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream
- History
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds.
-org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException:
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase
Expecting size of:
[]
to be greater than or equal to 2 but was 0 within 10 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
public static ContainerRuntime detectContainerRuntime() { | ||
return detectContainerRuntime(true); | ||
} | ||
|
||
public static ContainerRuntime detectContainerRuntime(List<ContainerRuntime> orderToCheckRuntimes) { | ||
public static ContainerRuntime detectContainerRuntime(ContainerRuntime... orderToCheckRuntimes) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to this change, all callers of detectContainerRuntime()
will fail with NoSuchMethodException unless they are recompiled. Let me send a PR to get the method back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes! Totally my bad @ppalaga . I can take care of it if you'd like
Although I can't reproduce #41085 I found some things which may cause it. See the conversation history in #41085.
Fixes #41085