Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete comment about JavaParser in WebSockets Next #41096

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 10, 2024

Java Parser 3.26 (which is already being used in Quarkus) should now work with Java 21 source code.

I am opening this as a draft so CI can run on my fork

@geoand geoand marked this pull request as ready for review June 10, 2024 14:48
@geoand geoand requested a review from mkouba June 10, 2024 14:48
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 10, 2024
Copy link

quarkus-bot bot commented Jun 10, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f86d662.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 974f4b9 into quarkusio:main Jun 10, 2024
35 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 10, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 10, 2024
@geoand geoand deleted the websockets-next-java21 branch June 11, 2024 05:28
@mkouba
Copy link
Contributor

mkouba commented Jun 11, 2024

Java Parser 3.26 (which is already being used in Quarkus) should now work with Java 21 source code.

@geoand Are you sure? I've just tried to build the main branch locally and got:

[ERROR] Failed to execute goal net.revelc.code:impsort-maven-plugin:1.10.0:sort (sort-imports) on project quarkus-websockets-next-deployment: Execution sort-imports of goal net.revelc.code:impsort-maven-plugin:1.10.0:sort failed: No enum constant com.github.javaparser.ParserConfiguration.LanguageLevel.JAVA_21

@geoand
Copy link
Contributor Author

geoand commented Jun 11, 2024

Indeed I saw the same this morning, so I'll revert this :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants