-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Path in GeneratedStaticResourceBuildItem #41066
Conversation
cc @mcruzdev |
I am currently testing it with the web-bundler |
8d7aeb6
to
4da6a17
Compare
Testing on web-bundler, I will test on Quinoa on monday |
It's good to merge if approved and CI is ok |
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't read the details, but the goals state look legit.
This PR:
Path
inGeneratedStaticResourceBuildItem
path
toendpoint
to be consistant withNotFoundPageDisplayableEndpointBuildItem
and not be confused with the file PathAdditionalStaticResourceBuildItem
will still be served in dev-mode to avoid breaking dev-mode on existing appsUsing
Path
instead ofbyte[]
allow to achieve live-reload without restarting Quarkus.