Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Path in GeneratedStaticResourceBuildItem #41066

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Jun 7, 2024

This PR:

  • adds support for Path in GeneratedStaticResourceBuildItem
  • renames path to endpoint to be consistant with NotFoundPageDisplayableEndpointBuildItem and not be confused with the file Path
  • adds normal and dev-mode tests for file based generated static resources
  • AdditionalStaticResourceBuildItem will still be served in dev-mode to avoid breaking dev-mode on existing apps

Using Path instead of byte[] allow to achieve live-reload without restarting Quarkus.

@ia3andy ia3andy added this to the 3.12 - main milestone Jun 7, 2024
@ia3andy
Copy link
Contributor Author

ia3andy commented Jun 7, 2024

cc @mcruzdev

@ia3andy ia3andy requested a review from FroMage June 7, 2024 15:59
@ia3andy
Copy link
Contributor Author

ia3andy commented Jun 7, 2024

I am currently testing it with the web-bundler

@ia3andy ia3andy force-pushed the add-generated-file-support branch from 8d7aeb6 to 4da6a17 Compare June 7, 2024 16:09
@ia3andy
Copy link
Contributor Author

ia3andy commented Jun 7, 2024

Testing on web-bundler, I will test on Quinoa on monday

@ia3andy
Copy link
Contributor Author

ia3andy commented Jun 7, 2024

It's good to merge if approved and CI is ok

Copy link

quarkus-bot bot commented Jun 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4da6a17.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.VertxTcpMetricsTest.testTcpMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:351)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:344)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read the details, but the goals state look legit.

@ia3andy ia3andy merged commit 797b3ef into quarkusio:main Jun 10, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants