Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid webjar to show 404 #41018

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix invalid webjar to show 404 #41018

merged 1 commit into from
Jun 6, 2024

Conversation

phillip-kruger
Copy link
Member

Fix #40991

@phillip-kruger phillip-kruger requested a review from geoand June 6, 2024 09:28
@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 6, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two comments.
Let's sort them out before merging please (even if it's to decide we keep it like that).

...ime/src/main/java/io/quarkus/webdependency/locator/runtime/WebDependencyLocatorRecorder.java Outdated Show resolved Hide resolved
...ime/src/main/java/io/quarkus/webdependency/locator/runtime/WebDependencyLocatorRecorder.java Show resolved Hide resolved
@phillip-kruger
Fix invalid webjar to show 404
ad8b37d 
Signed-off-by: Phillip Kruger <[email protected]>
@phillip-kruger phillip-kruger requested a review from gsmet June 6, 2024 12:17
@phillip-kruger
Copy link
Member Author

@gsmet, I changed to debug in the log output, There is no clean way to know exactly what will / can cause an exception, so doing a try/catch seems like the safe way for now.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 6, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ad8b37d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit b2c4549 into quarkusio:main Jun 6, 2024
20 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 6, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 6, 2024
@gsmet gsmet modified the milestones: 3.12 - main, 3.11.2 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
kind/bugfix
Projects
None yet
Milestone
3.11.2
Development

Successfully merging this pull request may close these issues.

Misspelled url for an webjar resource thows exception instead of 404
3 participants
@phillip-kruger @gsmet @geoand