Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets Next client: encode path param values automatically #40992

Merged
merged 1 commit into from
Jun 6, 2024
Merged

WebSockets Next client: encode path param values automatically #40992

merged 1 commit into from
Jun 6, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 5, 2024

@mkouba
Copy link
Contributor Author

mkouba commented Jun 5, 2024

@wabrit This pull request should fix the problem. It would be great if you could test it with your app...

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 5, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 76af842.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@wabrit
Copy link

wabrit commented Jun 6, 2024

Pleased to say my code now works fine with this fix, with no need to safe-encode params explicitly on my part.

@mkouba mkouba requested review from gastaldi and cescoffier June 6, 2024 11:19
@gastaldi gastaldi merged commit d7e022b into quarkusio:main Jun 6, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 6, 2024
@gastaldi
Copy link
Contributor

gastaldi commented Jun 6, 2024

@mkouba I've marked to backport it to 3.11

@gsmet gsmet modified the milestones: 3.12 - main, 3.11.2 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
kind/bugfix
Projects
None yet
Milestone
3.11.2
Development

Successfully merging this pull request may close these issues.

Params need double URL-safe-encoding for use with WebSocketConnector
5 participants
@mkouba @wabrit @gastaldi @cescoffier @gsmet