-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encryption secret to configuration #40969
Conversation
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Brutus5000, can you clarify something, do you have a client secret setup in your case ?
The note you added is informative but it is only relevant if no fallback to the client secret exists.
Perhaps we should add a note instead explaining it ?
I will continue the review next week since I'm on PTO
Thanks
@sberyozkin No, I have not set this up, as the OAuth client I use does not require/have a secret. |
@Brutus5000 OK, thanks for the confirmation. This is why I suggest to have a dedicated note, as opposed to adding the encryption secret property to this demo's configuration which already has a client secret fallback. Something like this, at the end of that section where the demo properties are introduced/explained:
Does it sound reasonable to you ? |
b536ef8
to
6440f49
Compare
@sberyozkin I adjusted the commit accordingly. |
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Brutus5000
Not setting an encryption-secret can cause unexpected behaviour. Each restart, even from hot reload, will pick a new encryption secret otherwise, invalidating existing logins. This is a very annoying behaviour during development.