Make -Dquickly a bit faster #40966
Merged
Make -Dquickly a bit faster #40966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/arc
gsmet
force-pushed
the
make-quickly-faster
branch
from
3062c2e to
9dc2082
Compare
This comment has been minimized.
This comment has been minimized.
ppalaga
reviewed
Jun 4, 2024
| @@ -525,6 +525,7 @@ | |||
| <executions> | |||
| <execution> | |||
| <id>enforce</id> | |||
| <phase>${maven-enforcer-plugin.phase}</phase> | |||
There was a problem hiding this comment.
This is a neat trick! I have not realized the phase can be set through a property.
|
Yeah, Surefire, Failsafe, impsort, formatter and even quarkus-maven-plugin:build are other good candidates to be handled in the same way. |
Instantiation the plugins can actually be costly when we have so many artifacts. For now, I have only applied this trick where it makes a great difference and has a low cost of maintenance. We could also do it for Surefire. Per a discussion with @ppalaga.
gsmet
force-pushed
the
make-quickly-faster
branch
from
9dc2082 to
3c88b37
Compare
aloubyansky
approved these changes
Jun 5, 2024
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiation the plugins can actually be costly when we have so many artifacts.
For now, I have only applied this trick where it makes a great difference and has a low cost of maintenance.
We could also do it for Surefire.
Per a discussion with @ppalaga.