-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arc - improve injection point transformation API #40841
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
0f31863
to
06cdf54
Compare
This comment has been minimized.
This comment has been minimized.
...s/arc/processor/src/main/java/io/quarkus/arc/processor/AnnotationsTransformationContext.java
Outdated
Show resolved
Hide resolved
...endent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InjectionPointInfo.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
...rojects/arc/processor/src/main/java/io/quarkus/arc/processor/InjectionPointsTransformer.java
Outdated
Show resolved
Hide resolved
...s/arc/processor/src/main/java/io/quarkus/arc/processor/AnnotationsTransformationContext.java
Show resolved
Hide resolved
...s/arc/processor/src/main/java/io/quarkus/arc/processor/AnnotationsTransformationContext.java
Outdated
Show resolved
Hide resolved
...endent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InjectionPointInfo.java
Outdated
Show resolved
Hide resolved
...rojects/arc/processor/src/main/java/io/quarkus/arc/processor/InjectionPointsTransformer.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
...endent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InjectionPointInfo.java
Outdated
Show resolved
Hide resolved
...rojects/arc/processor/src/main/java/io/quarkus/arc/processor/InjectionPointsTransformer.java
Outdated
Show resolved
Hide resolved
...s/arc/processor/src/main/java/io/quarkus/arc/processor/AnnotationsTransformationContext.java
Outdated
Show resolved
Hide resolved
...projects/arc/processor/src/main/java/io/quarkus/arc/processor/AnnotationsTransformation.java
Outdated
Show resolved
Hide resolved
LGTM, but I agree with @mkouba's comments. |
.../deployment/src/main/java/io/quarkus/smallrye/reactivemessaging/deployment/WiringHelper.java
Outdated
Show resolved
Hide resolved
extensions/grpc/deployment/src/main/java/io/quarkus/grpc/deployment/GrpcClientProcessor.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
2a3a41f
to
8213641
Compare
This comment has been minimized.
This comment has been minimized.
.../arc/deployment/src/main/java/io/quarkus/arc/deployment/TransformedAnnotationsBuildItem.java
Outdated
Show resolved
Hide resolved
I've changed the third commit and Let's see what CI has to say... |
.../arc/deployment/src/main/java/io/quarkus/arc/deployment/TransformedAnnotationsBuildItem.java
Outdated
Show resolved
Hide resolved
.../arc/deployment/src/main/java/io/quarkus/arc/deployment/TransformedAnnotationsBuildItem.java
Outdated
Show resolved
Hide resolved
…t being a method parameter
Status for workflow
|
Mine was just a question, I will let @mkouba approve and merge this one. |
Fixes #38856
First commit changes Arc's injection point transformation API. ATM the injection point
AnnotationTarget
is eitherFIELD
orMETHOD
, making it difficult to alter any annotation for single or multipleMETHOD_PARAMETER
targets underneath.Changes I introduce allow to operate directly on method parameters but in order to stay backward compatible, this requires new methods. The old ones are still in place, but I marked them as
@Deprecated(forRemoval=true)
Second commit changes all internal usages of the newly deprecated methods to their new variants.