Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling deserialization failures for Kafka documentation updated #40804

Merged
merged 1 commit into from
May 23, 2024

Conversation

SivaM07
Copy link
Contributor

@SivaM07 SivaM07 commented May 22, 2024

Post smallrye reactive messaging release 4.10.0, the deserialization failure handling has been upgraded to align with the failure strategy. The smallrye reactive documentation was updated, but the related quarkus documentation is still not yet updated.

This documentation change MR should also be back ported to 3.8 version.

Smallrye MR : https://github.com/smallrye/smallrye-reactive-messaging/pull/2256/files#diff-7bbf3222942af87ef0b2fdde53936b4a9e371b3968c8b09159430296cbefd042

Smallrye documentation: https://smallrye.io/smallrye-reactive-messaging/4.21.0/kafka/receiving-kafka-records/#handling-deserialization-failures

If fail-on-deserialization-failure attribute is set to false and the failure-strategy attribute is dead-letter-queue.
With Quarkus 3.2, the failed message won't be posted to DLQ
But starting from Quarkus 3.8, the failed message will be pushed to DLQ based on failure strategy

Documentation should mention that the message would be pushed to DLQ if the failure strategy is DLQ.
Otherwise unaware developers might end up implementing a custom failure handler to push it to DLQ.

Handling deserialization failures for Kafka documentation updated with impact of setting 'fail-on-deserialization-failure' as 'false' along with 'failure-strategy' as 'dead-letter-queue'
Copy link

quarkus-bot bot commented May 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8166e19.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented May 22, 2024

🙈 The PR is closed and the preview is expired.

@gsmet gsmet requested review from ozangunalp and cescoffier May 23, 2024 07:58
@cescoffier cescoffier merged commit 97e4f27 into quarkusio:main May 23, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants