Handling deserialization failures for Kafka documentation updated #40804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post smallrye reactive messaging release 4.10.0, the deserialization failure handling has been upgraded to align with the failure strategy. The smallrye reactive documentation was updated, but the related quarkus documentation is still not yet updated.
This documentation change MR should also be back ported to 3.8 version.
Smallrye MR : https://github.com/smallrye/smallrye-reactive-messaging/pull/2256/files#diff-7bbf3222942af87ef0b2fdde53936b4a9e371b3968c8b09159430296cbefd042
Smallrye documentation: https://smallrye.io/smallrye-reactive-messaging/4.21.0/kafka/receiving-kafka-records/#handling-deserialization-failures
If fail-on-deserialization-failure attribute is set to false and the failure-strategy attribute is dead-letter-queue.
With Quarkus 3.2, the failed message won't be posted to DLQ
But starting from Quarkus 3.8, the failed message will be pushed to DLQ based on failure strategy
Documentation should mention that the message would be pushed to DLQ if the failure strategy is DLQ.
Otherwise unaware developers might end up implementing a custom failure handler to push it to DLQ.