-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump org.jetbrains.kotlin:kotlin-bom from 1.9.23 to 2.0.0 #40745
Bump org.jetbrains.kotlin:kotlin-bom from 1.9.23 to 2.0.0 #40745
Conversation
This comment has been minimized.
This comment has been minimized.
7f81433
to
de9a957
Compare
This comment has been minimized.
This comment has been minimized.
de9a957
to
0621d7e
Compare
0621d7e
to
8d010ec
Compare
8d010ec
to
19a09f8
Compare
This comment has been minimized.
This comment has been minimized.
19a09f8
to
7fc7aa2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be ok. Now, I don't know how aggressive we need to be about this.
7fc7aa2
to
420656a
Compare
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
✔️ | JVM Tests - JDK 21 | Logs | Raw logs | 🔍 | ||
✖ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 17 Windows #
- Failing: integration-tests/rest-client
📦 integration-tests/rest-client
✖ Failed to execute goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore (wrong-host-truststore) on project quarkus-integration-test-rest-client: Execution wrong-host-truststore of goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore failed: java.net.ConnectException: Connection timed out: connect
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 integration-tests/reactive-messaging-kafka
✖ io.quarkus.it.kafka.KafkaConnectorTest.testRequestReply
- History
iterable contents differ at index [4], expected: <reply-5> but was: <{"details":"Error id d98f611f-390e-4ed7-916f-7aab5a999f4c-1, org.jboss.resteasy.spi.UnhandledException: io.smallrye.mutiny.TimeoutException","stack":"org.jboss.resteasy.spi.UnhandledException: io.smallrye.mutiny.TimeoutException\n\tat org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:107)\n\tat org.jboss.resteasy.core.ExceptionHandler.handleException(ExceptionHandler.java:344)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.writeException(SynchronousDispatcher.java:205)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:452)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.lambda$invokePropagateNotFound$6(SynchronousDispatcher.java:275)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:154)\n\tat org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchC...
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: iterable contents differ at index [4], expected: <reply-5> but was: <{"details":"Error id d98f611f-390e-4ed7-916f-7aab5a999f4c-1, org.jboss.resteasy.spi.UnhandledException: io.smallrye.mutiny.TimeoutException","stack":"org.jboss.resteasy.spi.UnhandledException: io.smallrye.mutiny.TimeoutException\n\tat org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:107)\n\tat org.jboss.resteasy.core.ExceptionHandler.handleException(ExceptionHandler.java:344)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.writeException(SynchronousDispatcher.java:205)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:452)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.lambda$invokePropagateNotFound$6(SynchronousDispatcher.java:275)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:154)\n\tat org.jboss.resteasy.core.interception.jaxrs.PreMatchCon...
⚙️ JVM Tests - JDK 17 Windows
📦 integration-tests/rest-client-reactive
✖ io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient
- History
Read timed out
-java.net.SocketTimeoutException
java.net.SocketTimeoutException: Read timed out
at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)
at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:355)
at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:808)
at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
at org.apache.http.impl.io.AbstractSessionInputBuffer.fillBuffer(AbstractSessionInputBuffer.java:161)
at org.apache.http.impl.io.SocketInputBuffer.fillBuffer(SocketInputBuffer.java:82)
Are we sure the Kotlin ecosystem is ready for Kotlin 2? I have no idea but that's probably something we need to check. |
@gsmet Can you elaborate on what Kotlin ecosystem you are specifically referring to? Other plugins? |
I don't know libraries, plugins, even users. I have no idea how stable Kotlin 2 is and if people want to move to it massively. Typically, for Scala, it took time. |
I believe the major impact is the introduction to the K2 compiler, but as instructed in https://kotlinlang.org/docs/whatsnew20.html#current-k2-compiler-limitations, one can revert back to Kotlin 1.9 by changing the compiler options, but yeah, the devil lies in the details |
Hi,
It could compile both with JVM and in Native with the mandrel image and it seemed to work :) (backend responded like usual) Concerning k2, It has just been released, so it's really fresh. But Jetbrains team claims that they have tested it against tons of project (https://blog.jetbrains.com/kotlin/2024/05/celebrating-kotlin-2-0-fast-smart-and-multiplatform/#migrate-with-confidence -> 80k backends, android, and multiproject). I haven't tested anything with gradle and Quarkus though. So no idea on this side. Cheers. |
@olivierbeltrandocintoo thanks for the valuable feedback! |
You are very welcome @gsmet . Another tiny feedback.
|
Bumps org.jetbrains.kotlin:kotlin-bom from 1.9.23 to 2.0.0.
Release notes
Sourced from org.jetbrains.kotlin:kotlin-bom's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin:kotlin-bom's changelog.
... (truncated)
Commits
e84e835
Add changelog for 2.0.0975dea2
Add changelog for 2.0.0-RC3b618ee4
[FIR] Prohibit referencing java field in case of conflict with property..b239239
K2: build outer classes sequence in FirImplicitBodyResolve properlyafc5b49
[IR] Assume IrFile has at least one offset entrybe1804c
[K/N][tests] Don't attempt to download simulator after first failureb666160
K2: fix captureFromExpressionInternal for nullable intersection typesf04f051
K2: fix withNullability() for ConeIntersectionTypecda1ad4
K2: reproduce KT-679128e0919e
[K2/JS] Use declaration session for looking up containing declarationYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)