Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message thrown when Quarkus REST and RESTEasy Classic are combined user-friendly again #40718

Merged

Conversation

michalvavrik
Copy link
Member

fixes: #40410

Due to the RESTEasy Reactive to Quarkus REST renaming, the test added in this PR is not backportable.

@michalvavrik michalvavrik changed the title Fix user-friendly Quarkus REST and RESTEasy combination err msg Fix user-friendly Quarkus REST and RESTEasy combination error message May 19, 2024
@michalvavrik michalvavrik changed the title Fix user-friendly Quarkus REST and RESTEasy combination error message Make error message thrown when Quarkus REST and RESTEasy Classic are combined user-friendly again May 19, 2024
Copy link

quarkus-bot bot commented May 19, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9e7462c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gsmet gsmet merged commit 6853477 into quarkusio:main May 20, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 20, 2024
@michalvavrik michalvavrik deleted the feature/fix-resteasy-quarkus-rest-err-msg branch May 20, 2024 20:22
@gsmet gsmet modified the milestones: 3.12 - main, 3.10.2 May 21, 2024
@gsmet gsmet modified the milestones: 3.10.2, 3.8.5 May 22, 2024
fedinskiy added a commit to quarkus-qe/quarkus-test-suite that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Less user friendly message when have rest and resteasy in one project
2 participants