Reinitialize shaded com.google.protobuf.UnsafeUtil class
#40698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adaptation of quarkusio#36642 for the shaded `com.google.protobuf.UnsafeUtil` class in kafka-clients. Fixes: quarkusio#40100
zakkak
commented
May 17, 2024
| @@ -1,10 +1,13 @@ | |||
| package io.smallrye.reactive.kafka.graal; | |||
There was a problem hiding this comment.
That's a weird package name for this class, isn't it???
There was a problem hiding this comment.
Probably safer to change it to avoid split packages in case SmallRye Reactive ends up having a graal package.
But can be done in another PR.
geoand
approved these changes
May 17, 2024
Status for workflow
|
cescoffier
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptation of #36642 for the
shaded
com.google.protobuf.UnsafeUtilclass in kafka-clients.Fixes: #40100