Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets Next: always use the managed Vertx instance in tests #40696

Merged
merged 2 commits into from
May 18, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 17, 2024

No description provided.

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label May 17, 2024
@mkouba mkouba requested a review from gastaldi May 17, 2024 11:56
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 17, 2024
Copy link

quarkus-bot bot commented May 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4120ac3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@geoand geoand merged commit 5af8899 into quarkusio:main May 18, 2024
51 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 18, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 18, 2024
@gsmet
Copy link
Member

gsmet commented May 18, 2024

@mkouba is the second commit just a cleanup or something that we should backport?

@mkouba
Copy link
Contributor Author

mkouba commented May 20, 2024

@mkouba is the second commit just a cleanup or something that we should backport?

Let's backport it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/vertx triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants