Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct JavaDoc example #40690

Merged
merged 2 commits into from
May 20, 2024
Merged

Correct JavaDoc example #40690

merged 2 commits into from
May 20, 2024

Conversation

cknoblauch
Copy link
Contributor

The example in the JavaDoc for @LookupIfProperty does not make sense unless both classes implement the Service interface.

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label May 16, 2024
@geoand geoand requested a review from mkouba May 17, 2024 05:34
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 17, 2024

This comment has been minimized.

Copy link

quarkus-bot bot commented May 18, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 96bef10.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ Native Tests - Data7 Failures Logs Raw logs 🚧

Failures

⚙️ Native Tests - Data7 #

- Failing: integration-tests/hibernate-reactive-mariadb 

📦 integration-tests/hibernate-reactive-mariadb

Failed to execute goal io.fabric8:docker-maven-plugin:0.44.0:build (docker-start) on project quarkus-integration-test-hibernate-reactive-mariadb: Unable to pull 'docker.io/mariadb:10.11' from registry 'docker.io' : received unexpected HTTP status: 503 Service Unavailable


Flaky tests - Develocity

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:49)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

@geoand geoand merged commit d539221 into quarkusio:main May 20, 2024
51 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 20, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 20, 2024
@gsmet gsmet modified the milestones: 3.12 - main, 3.11.0 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants