Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulsar doc misnamed variable, replace enableRetry with retryEnable #40604

Merged
merged 1 commit into from
May 14, 2024

Conversation

emilesalem
Copy link

@emilesalem emilesalem commented May 13, 2024

Fixes #40513

Copy link

quarkus-bot bot commented May 13, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/docs/feat/fix/refactor but be a proper sentence

This message is automatically generated by a bot.

@emilesalem emilesalem changed the title fix: pulsar doc, replace enableRetry with retryEnable Fix pulsar doc misnamed variable, replace enableRetry with retryEnable May 13, 2024

This comment has been minimized.

Copy link

github-actions bot commented May 13, 2024

🙈 The PR is closed and the preview is expired.

@emilesalem emilesalem force-pushed the fix/pulsar-doc-retry branch from 8d04d73 to 10b941c Compare May 13, 2024 18:39
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jackson Issues related to Jackson (JSON library) area/platform Issues related to definition and interaction with Quarkus Platform labels May 13, 2024
@emilesalem emilesalem force-pushed the fix/pulsar-doc-retry branch from 10b941c to b429b56 Compare May 13, 2024 18:39
Copy link

quarkus-bot bot commented May 13, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 10b941c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

This comment has been minimized.

@emilesalem emilesalem force-pushed the fix/pulsar-doc-retry branch from b429b56 to eb359cd Compare May 13, 2024 19:21
Copy link

quarkus-bot bot commented May 13, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit eb359cd.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
CI Sanity Check ⚠️ Check → 🚧
Documentation Build ⚠️ Check → 🚧

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute this fix!

@gsmet gsmet merged commit 091e062 into quarkusio:main May 14, 2024
2 of 5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 14, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.8.5 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/jackson Issues related to Jackson (JSON library) area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix
Projects
Development

Successfully merging this pull request may close these issues.

Apache Pulsar Reference Guide doc error
3 participants