-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce OidcRedirectFilter #40600
Introduce OidcRedirectFilter #40600
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
769ccb3
to
bd52f6f
Compare
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/OidcRedirectFilter.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
34ea209
to
a68d0ac
Compare
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/OidcRedirectFilter.java
Outdated
Show resolved
Hide resolved
a68d0ac
to
5028da3
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @gastaldi, I'd like now to wait a bit in case @pedroigor has some more comments, cheers |
5028da3
to
9a910fa
Compare
@gastaldi Sorry, there was a java docs typo, missing space, and some duplicate text, I only noticed after re-reading it a few times :-) |
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @pedroigor. |
Let me merge now, we can follow up early next week if needed. |
Proposing a backport to the 3.11 branch for this PR to make it to final 3.11.0 and to make #40539 useful in a mult-tenant OIDC setup |
Fixes #40562.
Simple PR which introduces a noteworthy feature, since an ability to customize OIDC redirects dynamically, especially in the presence of multiple OIDC providers, should become useful. Custom providers can add extra query parameters or set response headers as has been tried recently without success, or create secure cookies to help with generating better local redirect error or session expired pages. This PR simply runs every redirect URI through filters if they are available.
Summary for this PR's changes:
OidcRedirectFilter
s and run them for every redirect which can be done at theCodeAuthenticationMechanism
levelOidcUtils
method publicly accessible to help custom filters to create or remove cookies if they need toThis PR can be considered a follow up to #40539 - without this PR custom session expired pages can only be produced for single OIDC tenant setups.
Hope it can make to 3.11.0.CR1 or 3.11.0