Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore non-HTTP_2 requests #40454

Merged
merged 1 commit into from
May 6, 2024
Merged

Ignore non-HTTP_2 requests #40454

merged 1 commit into from
May 6, 2024

Conversation

alesj
Copy link
Contributor

@alesj alesj commented May 4, 2024

Fix for #39769.

@alesj alesj requested a review from cescoffier May 4, 2024 05:57
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label May 4, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@cescoffier
Copy link
Member

The change looks good, but you need to run the import sorter first.

cescoffier
cescoffier requested changes May 5, 2024
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impsort issue.

@alesj
Copy link
Contributor Author

alesj commented May 6, 2024

Impsort issue.

Fixed ...

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented May 6, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 92ced67.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier cescoffier merged commit 558774b into quarkusio:main May 6, 2024
35 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 6, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/grpc gRPC
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@alesj @cescoffier @gsmet