Avoid classes with incomplete hierarchy in Hibernate Validator

[gastaldi]

As explained in quarkiverse/quarkus-poi#102, some classes cannot be loaded because of an incomplete hierarchy

[gsmet]

Thanks for having a look. I spotted an issue but not sure why the tests are failing.

[yrodiere]

LGTM.

However, I'd like to point out a runtime class may have a complete class hierarchy at build time, yet have an incomplete one at runtime, because a superclass got excluded. Classes relying on XML parsers are a prime example of this, as we try to exclude XML parsers from runtime but still need them at build time.

So, I suspect this won't solve the problem completely. Still, it's a nice improvement, and maybe it'll fix that specific problem with Apache POI (did you check that?), so let's merge.

[yrodiere]

so let's merge

Well, let's merge once tests pass :]

[gastaldi]

maybe it'll fix that specific problem with Apache POI (did you check that?),

Yeap, I checked that and the error is gone, I'll investigate what's causing the other tests to fail

[gastaldi]

Apparently generated bytecode isn't visible during this build step. It barfs saying that io.quarkus.it.hibernate.orm.rest.data.panache.BooksResourceJaxRs_953025cf555c51e5ab5649f6462b7b6ff38e89ec isn't available in runtime. Still investigating the best solution, but pointers are welcome ;)

[gastaldi]

Because of #40383 (comment), I adopted a different strategy by performing the check in the Recorder class. Tests are passing locally for me

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4c575b3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[yrodiere]

LGTM. As far as I can tell loading these classes would happen anyway without your code, so it should not have much impact on startup time.

Let's merge if this still fixes the problem in POI.

Addressed

[gastaldi]

I can confirm this fixes quarkiverse/quarkus-poi#102. Merging