-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always populate metrics uri in presence of auth failures #40308
Conversation
geoand
commented
Apr 26, 2024
•
edited
Loading
edited
- Fixes: Micrometer URI templating does not apply for Forbidden requests #40305
The reason I have not added a test is that surfacing the problem requires a different security setup than the one of the existing integration tests and I am not terribly happy about adding yet another maven module. If we do think it's important however, I can go ahead and add it. |
It would be nice to find someway to exercise the code path, especially as it is rare (and we're less likely to notice if we break it). This could mean that we should think about a different way to test security paths altogether. |
This comment has been minimized.
This comment has been minimized.
The only way is to add another integration test module |
Status for workflow
|