Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Maven plugins versions now that we have a common parent #40216

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 23, 2024

We used to specify versions in all the independent projects and it's not necessary anymore.
Also fixes a few issues related to resource filtering as the updated version of the plugin seems to be a bit pickier.

@gsmet gsmet requested review from gastaldi and aloubyansky April 23, 2024 13:24
@quarkus-bot quarkus-bot bot added area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/funqy area/graphics area/platform Issues related to definition and interaction with Quarkus Platform labels Apr 23, 2024
Copy link

quarkus-bot bot commented Apr 23, 2024

/cc @Karm (awt), @galderz (awt)

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@gsmet gsmet force-pushed the unify-versions branch from 536b6ef to 82902a1 Compare June 6, 2024 16:28
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 6, 2024
@gsmet
Copy link
Member Author

gsmet commented Jun 6, 2024

I rebased this one. It should be ready to go once CI is green.

@gastaldi @geoand maybe let's wait for this one to get in before merging any Dependabot update updating the Maven plugins :).

This comment has been minimized.

@gsmet gsmet force-pushed the unify-versions branch from 82902a1 to ca15630 Compare June 7, 2024 12:51
We used to specify versions in all the independent projects and it's not
necessary anymore.
Also fixes a few issues related to resource filtering as the updated
version of the plugin seems to be a bit pickier.
@gsmet gsmet force-pushed the unify-versions branch from ca15630 to bcd1811 Compare June 7, 2024 12:52
Copy link

quarkus-bot bot commented Jun 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bcd1811.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Native Tests - Messaging1 Download .m2/repository/io/quarkus ⚠️ Check → Logs Raw logs 🚧

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@gsmet gsmet merged commit fcae2ab into quarkusio:main Jun 7, 2024
51 of 52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 7, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/funqy area/graphics area/maven area/platform Issues related to definition and interaction with Quarkus Platform triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants