Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go back to raw Maven read/write for bootstrap #39995

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Go back to raw Maven read/write for bootstrap #39995

merged 1 commit into from
Apr 10, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 10, 2024

Follow up of #39382. Per gripe from Alexey.

@gsmet gsmet requested review from gastaldi and aloubyansky April 10, 2024 16:51
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Apr 10, 2024
gastaldi
gastaldi approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aloubyansky
aloubyansky approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you!

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 10, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 10, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 68a1bbe.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@aloubyansky aloubyansky merged commit 051e910 into quarkusio:main Apr 10, 2024
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 10, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 10, 2024
@gsmet gsmet modified the milestones: 3.10.0.CR1, 3.9.4 Apr 17, 2024
@gsmet gsmet modified the milestones: 3.9.4, 3.8.5 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Milestone
3.8.5
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @gastaldi @aloubyansky