Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the tenant annotation check order in the OIDC renant resolver #39949

Merged

Conversation

sberyozkin
Copy link
Member

This PR does a minor OIDC tenancy doc update, as the Table of content is misaligned right now starting from https://quarkus.io/version/main/guides/security-openid-connect-multitenancy#tenant-resolution-order, so hopefully, after this PR, it will be much clearer from TOC alone what the order is.
And it does a minor optimization/fix to the OIDC DefaultTenantConfigResolver to align it with the docs: if the @Tenant annotation was used to resolve the tenant id, calling the dynamic custom TenantConfigResolver is wrong, I missed it during the recent refactoring which is all still on main only

Copy link

quarkus-bot bot commented Apr 8, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fc0e609.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Apr 8, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fc0e609.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit 79e2c51 into quarkusio:main Apr 8, 2024
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 8, 2024
@sberyozkin sberyozkin deleted the minor_oidc_tenancy_doc_updates branch April 8, 2024 15:41
Copy link

github-actions bot commented Apr 8, 2024

🙈 The PR is closed and the preview is expired.

@sberyozkin
Copy link
Member Author

@gastaldi @michalvavrik Thanks, will do a short tweet about all the options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants