Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property to enable/disable default client in Infinispan Dev Services #39918

Merged

Conversation

karesti
Copy link
Member

@karesti karesti commented Apr 5, 2024

Closes #39906

@quarkus-bot quarkus-bot bot added the area/infinispan Infinispan label Apr 5, 2024
@karesti
Copy link
Member Author

karesti commented Apr 5, 2024

This property should be helpful @jamesnetherton

@gsmet this should be backported to the latest LTS 🙏🏻

This comment has been minimized.

@karesti karesti force-pushed the disable-default-bean-configuration branch from 2d3c3a6 to a3b2c48 Compare April 6, 2024 06:45

This comment has been minimized.

@karesti karesti force-pushed the disable-default-bean-configuration branch from a3b2c48 to fb1cadc Compare April 6, 2024 07:21
Copy link

quarkus-bot bot commented Apr 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fb1cadc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 85510ce into quarkusio:main Apr 9, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Apr 9, 2024
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 9, 2024
@karesti karesti deleted the disable-default-bean-configuration branch April 10, 2024 08:01
@gsmet gsmet modified the milestones: 3.10.0.CR1, 3.8.5 May 15, 2024
@@ -259,7 +259,7 @@ private static class QuarkusInfinispanContainer extends InfinispanContainer {

public QuarkusInfinispanContainer(String clientName, InfinispanDevServicesConfig config,
LaunchMode launchMode, boolean useSharedNetwork) {
super(config.imageName.orElse(IMAGE_BASENAME + ":" + Version.getMajorMinor()));
super(config.imageName.orElse(IMAGE_BASENAME + ":" + Version.getVersion()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karesti you also changed this in this patch. What was the rationale? It doesn't look strictly related and I want to make sure that's something we want in 3.8.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getMajorMinor will retrieve 14.0 while getVersion will retrieve 14.0.16.Final image
We update images to map the latest minor. However, if the user has the image locally (14.0) won't get updated. There might be bugs that are fixed on the server that will still be present in the local machine of the user for this reason. Forcing with getVersion the dev service container image, we guarantee the user is running the same version locally and on the server.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit the change is kinda unrelated, but I was having some trouble so I added the change. Probably another PR would have been better

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think the rationale makes sense and we can backport it too.

@rsvoboda WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, let's have it @gsmet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is a problem in the end, because on product side we end up with something like quay.io/infinispan/server:14.0.27.Final-redhat-00001

I guess we need to get back to super(config.imageName.orElse(IMAGE_BASENAME + ":" + Version.getMajorMinor())); even for main because that would be a problem for the next feature release

Copy link
Member Author

@karesti karesti Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsvoboda I need to check with the team, but for upstream this is the best way for dev services, otherwise during N minor versions, fixes and updates, unless we always pull the image locally, it will potentially fail. For downstream I need to check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsvoboda I understand the issue, I'll change this back but I need to figure out how to avoid this problem in Quarkus upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infinispan Infinispan kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable default RemoteCacheManager configuration with Dev Services in Infinispan
4 participants