-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow finer tuning of shared network usage by DevServices #39899
Allow finer tuning of shared network usage by DevServices #39899
Conversation
Signed-off-by: Laurent Broudoux <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @yrodiere (elasticsearch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes perfect sense, thanks a lot!
This comment has been minimized.
This comment has been minimized.
Oh yes... I wasn't sure of the status of this part, and it wasn't on the critical path for my issue, so I chose the easy path. Let me know (@jtama and @geoand) if it's closely related and validated and I'll take some time to update the PR. |
It's really helpfull when you're outside of an extension, if you're developing an Test resource. |
@jtama can you provide @lbroudoux a suggestion on how to update the PR? |
I already did that just before. |
@lbroudoux is there anything you need from us to address the final concern? Thanks |
Hello! Sorry for late reply... I was travelling these last days. I think I'll be able to have a look at it this afternoon or tomorrow. Will keep you posted. |
🙏🏼 |
Signed-off-by: Laurent Broudoux <[email protected]>
This PR follows up on this discussion: #38398
and embeds enhancement for this issue: #39156
It allows finer tuning of shared network usage by DevServices.
By default, database-related DevServices make their container join the shared network as soon as it exists. At first, it was
only when running integration tests using a containerized application. However, there exist situations where the user wants to force the usage of a shared network, or other DevServices may require a shared network in dev or test mode (see the discussion and issue).
The proposed change allows us to clearly determine if joining a shared network is required (by the user, by integration test) so that DevServices can only join on purpose.
I'll prepare another PR for documentation update as explained in contribution guide.
Signed-off-by: Laurent Broudoux [email protected]