Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow finer tuning of shared network usage by DevServices #39899

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

lbroudoux
Copy link
Contributor

@lbroudoux lbroudoux commented Apr 5, 2024

This PR follows up on this discussion: #38398
and embeds enhancement for this issue: #39156

It allows finer tuning of shared network usage by DevServices.

By default, database-related DevServices make their container join the shared network as soon as it exists. At first, it was
only when running integration tests using a containerized application. However, there exist situations where the user wants to force the usage of a shared network, or other DevServices may require a shared network in dev or test mode (see the discussion and issue).

The proposed change allows us to clearly determine if joining a shared network is required (by the user, by integration test) so that DevServices can only join on purpose.

I'll prepare another PR for documentation update as explained in contribution guide.

Signed-off-by: Laurent Broudoux [email protected]

This comment was marked as resolved.

Copy link

quarkus-bot bot commented Apr 5, 2024

/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @yrodiere (elasticsearch)

@lbroudoux lbroudoux changed the title feat: Allow finer tuning of shared network usage by DevServices Allow finer tuning of shared network usage by DevServices Apr 5, 2024
@jtama
Copy link
Contributor

jtama commented Apr 5, 2024

@geoand geoand self-requested a review April 5, 2024 11:48
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes perfect sense, thanks a lot!

This comment has been minimized.

@lbroudoux
Copy link
Contributor Author

@lbroudoux there a network labeling point (https://github.com/quarkusio/quarkus/pull/39177/files#diff-eadbd09b0263a696107aca146819cd82f60481ca5879c0b1160c2f1f8fc02dbb)

Oh yes... I wasn't sure of the status of this part, and it wasn't on the critical path for my issue, so I chose the easy path. Let me know (@jtama and @geoand) if it's closely related and validated and I'll take some time to update the PR.

@jtama
Copy link
Contributor

jtama commented Apr 5, 2024

It's really helpfull when you're outside of an extension, if you're developing an Test resource.

@geoand
Copy link
Contributor

geoand commented Apr 9, 2024

@jtama can you provide @lbroudoux a suggestion on how to update the PR?

@jtama
Copy link
Contributor

jtama commented Apr 9, 2024

I already did that just before.
@lbroudoux Do you need more?

@geoand
Copy link
Contributor

geoand commented Apr 11, 2024

@lbroudoux is there anything you need from us to address the final concern?

Thanks

@lbroudoux
Copy link
Contributor Author

Hello! Sorry for late reply... I was travelling these last days. I think I'll be able to have a look at it this afternoon or tomorrow. Will keep you posted.

@geoand
Copy link
Contributor

geoand commented Apr 11, 2024

🙏🏼

@lbroudoux
Copy link
Contributor Author

Hey @geoand and @jtama!
I just added a commit to report the network labeling point. Sorry for delay.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 11, 2024
@geoand geoand merged commit 9929c7d into quarkusio:main Apr 12, 2024
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 12, 2024
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to ask for devservices to use the shared network
3 participants