-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn users when using older GraalVM or Mandrel versions #39866
Warn users when using older GraalVM or Mandrel versions #39866
Conversation
Although we try to keep backwards compatibility with older GraalVM or Mandrel versions, these versions should not be considered as fully supported by the users, as the compatibility might break at any time (even at a minor level patch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good move. I'd be even more aggressive on the minimum version, but that's probably for another day.
/** | ||
* The minimum version of GraalVM supported by Quarkus. | ||
* Versions prior to this are expected to cause major issues. | ||
*/ | ||
public static final Version MINIMUM = VERSION_22_2_0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be 23.0
(JDK 17-based), by now for quarkus main. 22.2.0 is very old. Failing that, use 22.3.0 at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why though? By bumping MINIMUM
we (mandrel team) will no longer be able to do tests with these versions (mostly to see the evolution through time or to see in which version a regression was introduced) even if there is no major "breakage". So far there is no extra effort required on our side to keep this as is. cc @galderz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this being tested anywhere with Quarkus main, so unless you can show this actually works with 22.2, there is no point in keeping it.
Status for workflow
|
Follow up to quarkusio#37828 (comment) and quarkusio#39866 (comment) (cherry picked from commit 1b6033b)
Follow up to quarkusio#37828 (comment) and quarkusio#39866 (comment) (cherry picked from commit 1b6033b)
Follow up to quarkusio#37828 (comment) and quarkusio#39866 (comment) (cherry picked from commit 1b6033b)
Follow up to quarkusio#37828 (comment) and quarkusio#39866 (comment) (cherry picked from commit 1b6033b)
Although we try to keep backwards compatibility with older GraalVM or
Mandrel versions, these versions should not be considered as fully
supported by the users, as the compatibility might break at any
time (even at a minor level patch).