Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the logged process ID is correct in native mode #39856

Closed
wants to merge 2 commits into from

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 3, 2024

@geoand
Copy link
Contributor Author

geoand commented Apr 3, 2024

@zakkak another instance of the image metrics test causing issues:

2024-04-03T10:22:46.7791862Z 2024-04-03 10:22:46,761 INFO  [io.quarkus] (main) Installed features: [agroal, cdi, hibernate-orm, hibernate-validator, jdbc-h2, jdbc-postgresql, micrometer, narayana-jta, narayana-lra, resteasy, resteasy-client, resteasy-jackson, resteasy-jaxb, resteasy-jsonb, resteasy-mutiny, scheduler, security, security-properties-file, servlet, smallrye-context-propagation, smallrye-fault-tolerance, smallrye-health, smallrye-openapi, swagger-ui, vertx, websockets, websockets-client]
2024-04-03T10:22:46.8258981Z [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.666 s <<< FAILURE! -- in io.quarkus.it.main.ImageMetricsITCase
2024-04-03T10:22:46.8263218Z [ERROR] io.quarkus.it.main.ImageMetricsITCase.verifyImageMetrics -- Time elapsed: 0.002 s <<< FAILURE!
2024-04-03T10:22:46.8265776Z org.opentest4j.AssertionFailedError: Expected analysis_results.classes.jni to be within range [62 +- 1%] but was 63 ==> expected: <true> but was: <false>
2024-04-03T10:22:46.8267631Z 	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
2024-04-03T10:22:46.8269173Z 	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@dmlloyd
Copy link
Member

dmlloyd commented Apr 3, 2024

Hmm I think this indicates at least two bugs. In both the SmallRye and LogManager case, we should use the JDK API to get the PID; we must be caching it. I'll have a look today.

@dmlloyd
Copy link
Member

dmlloyd commented Apr 3, 2024

@geoand
Copy link
Contributor Author

geoand commented Apr 3, 2024

💪🏼

@geoand
Copy link
Contributor Author

geoand commented Apr 3, 2024

Closing this

@geoand geoand closed this Apr 3, 2024
@dmlloyd
Copy link
Member

dmlloyd commented Apr 3, 2024

@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport-3.8 triage/backport labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'quarkus.log.console.format' '%i' Process ID fixed at build time
2 participants