Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmallRye OpenAPI: add missing @Inject annotation #39827

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Apr 2, 2024

This makes sure the code works in CDI strict mode as well.

Fixes #39779

This makes sure the code works in CDI strict mode as well.
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

@gsmet
Copy link
Member

gsmet commented Apr 2, 2024

This is interesting. I'm wondering if it's the only one causing potential issues in strict mode.

@mkouba
Copy link
Contributor

mkouba commented Apr 2, 2024

This is interesting. I'm wondering if it's the only one causing potential issues in strict mode.

I doubt it. Any extension that relies on a non-standard feature that is in conflict with the strict mode may be broken...

@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 2, 2024

There's many other problems like this in the code base, for sure. My personal recommendation is to not use the strict mode, because it doesn't really add anything. The only reason why we [have to] have it is that we've made some things optional that the specification considers mandatory, and the TCK verifies that. If someone decides to use it anyway, they will find issues like this, which are fairly straightforward to resolve.

Copy link

quarkus-bot bot commented Apr 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cafdea1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@Ladicek Ladicek merged commit 2f687bb into quarkusio:main Apr 2, 2024
24 checks passed
@Ladicek Ladicek deleted the add-inject-annotation branch April 2, 2024 09:45
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants