Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer single char String intrinsics over String one #39806

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

franz1981
Copy link
Contributor

No description provided.

@@ -6,7 +6,7 @@
public class MatrixParamHandler implements ServerRestHandler {
@Override
public void handle(ResteasyReactiveRequestContext requestContext) throws Exception {
if (requestContext.getPath().contains(";")) {
if (requestContext.getPath().indexOf(';') != -1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this makes sense, this handler is rarely used

Copy link
Contributor Author

@franz1981 franz1981 Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it is a minor I have found by reading few flamegraphs these days, but it can be ignored if we don't care really...
Although I would like to understand why I have found it, given it should be rarely used

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can certainly include it, there is absolutely no harm done!

And actually I was wrong before... The handler is always called, it's just that if statement is rarely true (as HTTP Matrix params are rarely used).

@geoand geoand marked this pull request as ready for review April 1, 2024 13:07
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 1, 2024
Copy link

quarkus-bot bot commented Apr 1, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e615c43.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@geoand geoand merged commit 0bb2be5 into quarkusio:main Apr 1, 2024
56 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 1, 2024
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants