-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer single char String intrinsics over String one #39806
Conversation
@@ -6,7 +6,7 @@ | |||
public class MatrixParamHandler implements ServerRestHandler { | |||
@Override | |||
public void handle(ResteasyReactiveRequestContext requestContext) throws Exception { | |||
if (requestContext.getPath().contains(";")) { | |||
if (requestContext.getPath().indexOf(';') != -1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this makes sense, this handler is rarely used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, it is a minor I have found by reading few flamegraphs these days, but it can be ignored if we don't care really...
Although I would like to understand why I have found it, given it should be rarely used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can certainly include it, there is absolutely no harm done!
And actually I was wrong before... The handler is always called, it's just that if
statement is rarely true (as HTTP Matrix params are rarely used).
Status for workflow
|
No description provided.