Add shared support for MongoDB Dev Services container #39787

patrox · 2024-03-29T14:15:27Z

No description provided.

gsmet

Thanks for this PR. It looks very nice.

I added a few minor gripes inline as to preferring MongoDB/mongodb over mongo. I'm not sure it makes sense in all circumstances so feel free to push back if it doesn't.

Could you also squash all your commits when done?

Thanks!

gsmet · 2024-04-03T15:19:26Z

...client/deployment/src/main/java/io/quarkus/mongodb/deployment/DevServicesMongoProcessor.java

+     */
+    private static final String DEV_SERVICE_LABEL = "quarkus-dev-service-mongo";
+
+    private static final ContainerLocator mongoContainerLocator = new ContainerLocator(DEV_SERVICE_LABEL, MONGO_EXPOSED_PORT);


The constant should probably be named like a constant.

gsmet · 2024-04-03T15:20:28Z

...lient/deployment/src/main/java/io/quarkus/mongodb/deployment/DevServicesBuildTimeConfig.java

@@ -45,4 +45,30 @@ public class DevServicesBuildTimeConfig {
    @ConfigItem
    public Map<String, String> containerEnv;

+    /**
+     * Indicates if the Mongo server managed by Quarkus Dev Services is shared.


Could you make sure you use MongoDB instead of Mongo in the javadoc of the configuration properties? They are published on the website.
(Note that other properties might not comply but let's not add more :))

Sure, will fix it. Naming is so hard ;)

...client/deployment/src/main/java/io/quarkus/mongodb/deployment/DevServicesMongoProcessor.java

gsmet · 2024-04-03T15:21:58Z

docs/src/main/asciidoc/mongodb-dev-services.adoc

+
+If you need multiple (shared) servers, you can configure the `quarkus.mongo.devservices.service-name` attribute and indicate the server name.
+It looks for a container with the same value, or starts a new one if none can be found.
+The default service name is `mongo`.


Any chance we could make it mongodb or it is a convention and we should keep it that way?

It can be changed

@patrox are you sure you pushed your changes? I don't see my comments addressed and also you said you squashed everything and the commits are not.

Thanks for your feedback!

@patrox are you sure you pushed your changes? I don't see my comments addressed and also you said you squashed everything and the commits are not.

Thanks for your feedback!

Yeah sorry, it looks like I messed things up during rebase. Now it should be fine :)

@gsmet Now all requested changes should be in place, the commits were squashed and the branch is up-to-date with the current main, so it looks ready!

docs/src/main/asciidoc/mongodb-dev-services.adoc

patrox · 2024-04-04T19:46:59Z

Thanks for this PR. It looks very nice.

I added a few minor gripes inline as to preferring MongoDB/mongodb over mongo. I'm not sure it makes sense in all circumstances so feel free to push back if it doesn't.

Could you also squash all your commits when done?

Thanks!

@gsmet I've addressed all your suggestions/comments and squashed all commits after rebasing to the current main.

github-actions · 2024-04-18T09:15:04Z

🙈 The PR is closed and the preview is expired.

gsmet

I amended your commit to fix DEV_SERVICE_LABEL that was still the mongo version.

LGTM, let's merge when CI is green.

Sorry it took so much time for me to get back to it :).

quarkus-bot · 2024-06-06T18:28:39Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 164e21b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

patrox · 2024-06-06T19:17:56Z

I amended your commit to fix DEV_SERVICE_LABEL that was still the mongo version.

LGTM, let's merge when CI is green.

Sorry it took so much time for me to get back to it :).

Thank you @gsmet, will wait for the CI to become 🟢

quarkus-bot · 2024-06-07T00:21:12Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 164e21b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer/deployment

✖ io.quarkus.micrometer.deployment.binder.VertxTcpMetricsTest.testTcpMetrics - History

event executor terminated - java.util.concurrent.RejectedExecutionException

java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:351)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:344)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

⚙️ Maven Tests - JDK 17

📦 integration-tests/maven

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange - History

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes. - java.lang.RuntimeException

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:86)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange(RemoteDevMojoIT.java:100)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange - History

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes. - java.lang.RuntimeException

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:86)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange(RemoteDevMojoIT.java:100)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)

gsmet · 2024-06-07T08:36:25Z

@patrox thanks for your contribution, it's going to be part of 3.12.

quarkus-bot bot added area/documentation area/mongodb labels Mar 29, 2024

patrox mentioned this pull request Mar 29, 2024

Shared DevServices Container for MongoDB Like Kafka in Quarkus #38678

Open