Change to receive files outside the classpath in mongodb liquibase

[juanjogv]

Due to the nature in which the resourceAccessor was created and injected when instantiating the Liquibase class
in LiquibaseMongodbFactory.createLiquibase()

try (ClassLoaderResourceAccessor resourceAccessor = new ClassLoaderResourceAccessor(Thread.currentThread().getContextClassLoader()))

it was not possible to pass a changeLog outside the classpath via liquibase-mongodb.change-log property. For people like me who want to use the quarkus-liquibase-mongodb extension only with the dev and test profiles in conjunction with the devservices and in productive environments use the liquibase cli directly this implementation is a bit problematic.

I also took the opportunity to implement the search-path property described in: docs.liquibase which allows me to limit the scope of the DirectoryResourceAccessor and not give it the default value of DirectoryResourceAccessor(Paths.get("/")).

• Closes: Receive files outside the classpath in quarkus-liquibase-mongodb #39683

[gsmet]

Thanks a lot for this pull request! I like what you did here and bonus point for making sure we weren't breaking the previous behavior.

Any chance you could have a look if the standard Liquibase could use the same treatment (it could be done in another PR)?

Also, I added a few very small comments.

[juanjogv]

Thanks a lot for this pull request! I like what you did here and bonus point for making sure we weren't breaking the previous behavior.

Any chance you could have a look if the standard Liquibase could use the same treatment (it could be done in another PR)?

Also, I added a few very small comments.

I just uploaded a commit with the changes you suggested. Now about checking the standard Liquibase, sure! no problem, as soon as I have some free time I will check the code to make sure that the same treatment is done to the changelog.

[juanjogv]

Already did the PR in the standard Liquibase extension.

[loicmathieu]

LGTM, thanks.

As I saw that @gsmet already look at it I'll let him merge.

[geoand]

Thanks for this!

I would like to have (at least) the last two commits squashed into the previous ones - FWIW if I made this change I would probably just make it one commit

[juanjogv]

Ready the squash of the last two commits into a single one.

[geoand]

I looked at the commits again and actually I think it makes a lot more sense to have a single one since are all about one new feature that is continuously revised. Those revisions make sense when developing, but they don't add much once the feature is complete.

Thereofore. can you please squash into a single commit? Once that's done we can merge (assuming CI is all green)

[juanjogv]

Ready the squash of all commits into a single one.

[geoand]

Thanks!

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7297a5f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[juanjogv]

@geoand can you help me with this PR? is just a replication of the things done here into the standard liquibase extension.

[geoand]

I'll have a look next week.

Thanks for your contributions!