Avoid running useless goals in subsequent CI builds #39647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/infra-automation
This comment has been minimized.
This comment has been minimized.
gsmet
force-pushed
the
disable-useless-goals
branch
from
41fa912 to
1bd733b
Compare
This comment has been minimized.
This comment has been minimized.
The Initial JDK build is supposed to check all the constraints before running the tests. Given we don't have platform specific constraints, it should be safe to avoid running these particular goals.
gsmet
force-pushed
the
disable-useless-goals
branch
from
1bd733b to
f79056c
Compare
Status for workflow
|
aloubyansky
approved these changes
Mar 26, 2024
|
Yes, it's ok to run them on the initial build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Initial JDK build is supposed to check all the constraints before running the tests.
Given we don't have platform specific constraints, it should be safe to avoid running these particular goals.
@aloubyansky could you check that I'm actually correct for
-DskipExtensionValidation -DskipCodestartValidation? My understanding is that running them once for the Initial JDK build is enough but if you think it's not a good idea, we can revisit.