Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.8.3 backports 1 #39466

Merged
merged 35 commits into from
Mar 15, 2024
Merged

3.8.3 backports 1 #39466

merged 35 commits into from
Mar 15, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 15, 2024

Please don't merge, I will merge it myself.

geoand and others added 30 commits March 15, 2024 09:53
(cherry picked from commit 69822c5)
Before this, the mutiny version would recreate the delegate instead
of reusing the existing bean

Fixes: quarkusio#39047
(cherry picked from commit d894149)
(cherry picked from commit 4d6fc50)
(cherry picked from commit bda2602)
(cherry picked from commit 638497b)
This means not keeping the entire content of the stream in memory

(cherry picked from commit f44d29c)
correction in typo for profile and profiles tags

(cherry picked from commit f67e630)
(cherry picked from commit b84c8fe)
(cherry picked from commit 30c1aa6)
Co-authored-by: Stéphane Épardaud <[email protected]>
(cherry picked from commit c475ad9)
Bumps org.apache.commons:commons-compress from 1.26.0 to 1.26.1.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-compress
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit 2e8c8db)
This is done to ensure that the use of Metrics does not force the
creation of EntityManagerFactory before extensions like
Liquibase or Flyway have had the chance to update the database
schema.

Fixes: quarkusio#39145
(cherry picked from commit e6d1cd2)
It appears that failure to do so results in the generated
metadata not automatically including them (as opposed to what
the javadoc of @HttpTrigger says)

Fixes: quarkusio#39242
(cherry picked from commit 73761f0)
(cherry picked from commit 0213917)
Starting with 23.1 `org.graalvm.sdk:graal-sdk` (which was introduced in
22.3) is just a wrapper (for backwards compatibility) that depends on
the new (in 23.1) artifacts:

* `org.graalvm.sdk:collections`
* `org.graalvm.sdk:nativeimage`
* `org.graalvm.sdk:word`
* `org.graalvm.polyglot:polyglot`

The APIs that Quarkus depends on are all packaged in
`org.graalvm.sdk:nativeimage` so there is no need to depend on the rest.

To make matters worse, fetching `org.graalvm.polyglot:polyglot` seems to
complicate things, see
quarkusio#39350.

(cherry picked from commit 71bcbb2)
When a REST Client interface is part of a library or the runtime part
of an extension, it's not uncommon to forget to index the module.
When that happens, we now provide a proper error message.

(cherry picked from commit 573e595)
If a synthetic bean creation function is backed by a `Supplier`, `Function`,
`RuntimeValue` or a runtime proxy, that creation function is stored into
a `Map` during application startup and later retrieved when needed.

The key under which it is stored into the `Map` is wrong, as it only contains
the name of the implementation class and a hash of bean types and qualifiers.
When there are multiple synthetic beans with the same implementation class,
types and qualifiers, only one creation function is used for all of them.

This commit fixes that by including the synthetic bean identifier in the hash,
making creation function key unique for each synthetic bean.

(cherry picked from commit b0b898a)
with the same groupId and artifactId

(cherry picked from commit cd93135)

This comment has been minimized.

Copy link

github-actions bot commented Mar 15, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Mar 15, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c73bb1e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Mar 15, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c73bb1e.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍
Quickstarts Compilation - JDK 17 Compile Quickstarts ⚠️ Check → Logs Raw logs 🚧

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: integration-tests/virtual-threads/grpc-virtual-threads 

📦 integration-tests/virtual-threads/grpc-virtual-threads

io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testStreamingOutputCall - History - More details - Source on GitHub

io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.Status.asRuntimeException(Status.java:537)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:631)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
	at io.quarkus.grpc.example.streaming.VirtualThreadTestBase.testStreamingOutputCall(VirtualThreadTestBase.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:1013)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:827)

@gsmet gsmet merged commit d52f3bc into quarkusio:3.8 Mar 15, 2024
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.