-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve OIDC client reference document #39367
Improve OIDC client reference document #39367
Conversation
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
@sheilamjones I've noticed Rolfe is away, would you be OK with doing a review. The actual text changes are quite limited, but I'm asking the Doc team to check given that it will be eventually synced to the downstream docs. May be I can just merge as the team will likely be doing the whole doc review later anyway. |
Hi @sberyozkin, sure, I will take a look now. |
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
Hi @sberyozkin, I completed a review focusing on your changes only. I just had some minor comments for your consideration and also a couple of questions. Hope this helps. |
Hi @sheilamjones Thanks very much for the prompt review, applied all proposed changes, and I'll also do a minor clarification re the header and the scheme, thanks |
e2e7802
to
68229c0
Compare
Status for workflow
|
Status for workflow
|
Let me merge it now, so that I can link to the doc snapshots showing the generated properties, thanks @sheilamjones @gastaldi. Sheila, FYI, I only did a minor update after applying your suggestions, with Thanks |
These changes should be backportable I hope |
Sorry, @sheilamjones, if you think I merged too early, let me know, I'll apply other suggestions you may have right away :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The OIDC client reference document has some problems at the moment:
OidcClient
is used directly are pretty bad, they were added awhile back, the assumption was the users who chose to useOidcClient
directly would write some code manually acquiring and refreshing tokens, but it is not good for new usersSo this PR does the following:
quarkus-oidc-token-propagation-reactive
because the directory has not been changed - but the generated properties correctly show thequarkus.rest-client-oidc-token-propagation
namespace)tenant-id
attribute is mentioned@rolfedh Can you please do a Doc team check on this PR, mostly, these are code examples, but there is a bit if extra text there as well