Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Security WebAuth config classes to @ConfigMapping #39357

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

michalvavrik
Copy link
Member

We try to migrate config classes to interfaces those of the OIDC-related extensions where it shouldn't break thing (we are not aware of reasons why users should inject migrated config classes or of Quarkiverse extensions that use that extension). That effort is tracked here #39185.

I mentioned when going through security-related extensions that WebAuth should fit this criteria https://mvnrepository.com/artifact/io.quarkus/quarkus-security-webauthn/usages. I don't see config classes mentioned in https://quarkus.io/guides/security-webauthn nor I can see user-defined beans that should inject it in most cases. Hence I propose to also migrate Security WebAuth for reasons discusses in the related above-mentioned issue.

Copy link

quarkus-bot bot commented Mar 12, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7396dae.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@FroMage FroMage merged commit 6fb844e into quarkusio:main Mar 12, 2024
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 12, 2024
@michalvavrik michalvavrik deleted the feature/security-webauth branch March 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants