Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the client and tenant id to OIDC request filters #39328

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

sberyozkin
Copy link
Member

Fixes #39320

If the application has multiple OIDC client or OIDC server configurations then distinguishing between them in custom OIDC request filters using the request URI only can be difficult.
So the client-id is passed when the filters are applied to quarkus-oidc-client requests and the tenant-id when the filters are applied to quarkus-oidc requests, Having differently named attributes will help if the quarkus-oidc-client is used in the endpoints secured with quarkus-oidc, in which case the filter will be called by both server-side and client-side OIDC extensions - though we may also add a Scope annotation (Scope.SERVER, Scope.CLIENT) later to help in such advanced cases

@sberyozkin sberyozkin requested a review from gastaldi March 11, 2024 14:49
Copy link

quarkus-bot bot commented Mar 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 96e162c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit fd062d2 into quarkusio:main Mar 11, 2024
22 checks passed
@sberyozkin sberyozkin deleted the oidc_client_name_in_filter branch March 11, 2024 16:37
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 11, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus OIDC Client: OidcRequestFilter is missing OIDC client name information
2 participants