Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Little rework of DevUi documentation #39235

Closed
wants to merge 1 commit into from

Conversation

allemas
Copy link

@allemas allemas commented Mar 6, 2024

Little improvement in Dev Ui documentation.

As discussed here I struggled to understand devui isn't launched with prod QUARKUS_PROFILE #39027

The idea is to be more clear and not lost the user with extensions implementations details.

Open to any suggestions, hope this help.

Copy link

quarkus-bot bot commented Mar 6, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8e83e5d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented Mar 6, 2024

🙈 The PR is closed and the preview is expired.

@geoand geoand requested a review from rolfedh March 7, 2024 11:16
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this proposal. I added some comments.

For me, the only change we should make is to change the title of the guide to Dev UI for extension developers


image::dev-ui-overview-v2.png[alt=Dev UI overview,role="center"]
When you start quarkus with `mvn quarkus:dev` the Dev ui is available at http://localhost:8080/q/dev-ui[/q/dev-ui] by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When you start quarkus with `mvn quarkus:dev` the Dev ui is available at http://localhost:8080/q/dev-ui[/q/dev-ui] by default.
When you start Quarkus with `mvn quarkus:dev` the Dev UI is available at http://localhost:8080/q/dev-ui[/q/dev-ui] by default.

- view and change `Configuration`
- manage and visualize `Continuous Testing`
- view `Dev Services` information
- view the Build information
- view and stream various logs


_In de prod QUARKUS_PROFILE the Dev ui is not available, see the documentation on how https://quarkus.io/guides/config-reference#default-profiles[configure it]_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're trying to say here? We already state previously that the Dev UI is available in dev mode.

Also this guide is for extension authors, not for general considerations about the Dev UI.

@@ -15,37 +15,45 @@ include::_attributes.adoc[]
This guide covers the Dev UI v2, which is the default from Quarkus 3 onwards.
====

This guide covers the Quarkus Dev UI for xref:building-my-first-extension.adoc[extension authors].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is very important and should stay at the top.
This guide is for extension developers.

I think what actually needs an adjustment is the title of the guide.

For the rest, I think I prefer the current content to your proposal as this guide has a very precise purpose and is not a general Dev UI guide.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your dedication and the effort you've put into your contributions, @allemas. After careful consideration, it appears that the reviewer has decided to maintain the existing content as it closely aligns with our current goals and guidelines. Therefore, it looks like we'll be closing this PR. However, your input is highly valued, and I plan to initiate a follow-up PR to update the title, incorporating aspects of your suggestions where applicable. We genuinely appreciate your understanding and look forward to your continued contributions to our project.

@allemas allemas closed this Mar 10, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants