Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for IO utils and add thread info in build logs #39214

Merged

Conversation

galderz
Copy link
Member

@galderz galderz commented Mar 6, 2024

This is the logging I added to figure out what was going on in #39210.

  • Add additional logging on IO utils methods to detect potential issues with concurrent build steps.
  • Print thread information for DEBUG or TRACE log messages in build logs.

* Add additional logging on IO utils methods to detect
potential issues with concurrent build steps.
* Print thread information for DEBUG or TRACE log messages
in build logs.
@galderz galderz requested review from gastaldi and geoand March 6, 2024 07:55
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Mar 6, 2024
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 6, 2024
Copy link

quarkus-bot bot commented Mar 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bbb4e2e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/websockets-next/server/deployment

io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.testLoMultiBidi - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.assertBroadcast(BroadcastOnOpenTest.java:104)

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.EndUserEnabledTest.baseTest - History

  • AttributesMap{data={http.route=/otel/enduser, code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.method=GET, http.scheme=http, net.protocol.name=http, code.function=dummy, http.target=/otel/enduser, http.status_code=200, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/21.0.2), net.host.port=8081, http.response_content_length=0, http.client_ip=127.0.0.1}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: AttributesMap{data={http.route=/otel/enduser, code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.method=GET, http.scheme=http, net.protocol.name=http, code.function=dummy, http.target=/otel/enduser, http.status_code=200, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/21.0.2), net.host.port=8081, http.response_content_length=0, http.client_ip=127.0.0.1}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
	at io.quarkus.it.opentelemetry.EndUserEnabledTest.evaluateAttributes(...

@geoand geoand merged commit 2562a34 into quarkusio:main Mar 6, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 6, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 6, 2024
@galderz galderz deleted the topic.0305.native-jar-building-extra-logging branch June 4, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants