Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export security events as OpenTelemetry Span Events #39207

Conversation

michalvavrik
Copy link
Member

closes: #38008

Copy link

quarkus-bot bot commented Mar 5, 2024

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@michalvavrik michalvavrik requested a review from brunobat March 5, 2024 21:28
@michalvavrik michalvavrik force-pushed the feature/security-events-as-otel-span-events branch from af60120 to 45c42ba Compare March 5, 2024 21:29

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Mar 5, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik, this is looking really good.
Left some minor comments.

@michalvavrik michalvavrik force-pushed the feature/security-events-as-otel-span-events branch from 45c42ba to 3d08150 Compare March 6, 2024 10:03
Copy link

quarkus-bot bot commented Mar 6, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 3d08150.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @michalvavrik

Copy link

quarkus-bot bot commented Mar 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3d08150.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.EndUserEnabledTest.baseTest - History

  • AttributesMap{data={code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.route=/otel/enduser, net.protocol.name=http, http.scheme=http, http.method=GET, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/17.0.10), code.function=dummy, http.target=/otel/enduser, net.host.port=8081, http.response_content_length=0, http.client_ip=127.0.0.1, http.status_code=200}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: AttributesMap{data={code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.route=/otel/enduser, net.protocol.name=http, http.scheme=http, http.method=GET, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/17.0.10), code.function=dummy, http.target=/otel/enduser, net.host.port=8081, http.response_content_length=0, http.client_ip=127.0.0.1, http.status_code=200}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
	at io.quarkus.it.opentelemetry.EndUserEnabledTest.evaluateAttributes...

@michalvavrik
Copy link
Member Author

/cc @sberyozkin

@brunobat brunobat merged commit dc10a9d into quarkusio:main Mar 7, 2024
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 7, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 7, 2024
@michalvavrik michalvavrik deleted the feature/security-events-as-otel-span-events branch March 7, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Export security events as OTel Events
2 participants