Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.8.2 backports 1 #39198

Merged
merged 34 commits into from
Mar 6, 2024
Merged

3.8.2 backports 1 #39198

merged 34 commits into from
Mar 6, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 5, 2024

Please don't merge, I will merge it myself.

ozangunalp and others added 30 commits March 5, 2024 19:51
Resolves split package on health package issue quarkusio#38711

(cherry picked from commit e530ff1)
(cherry picked from commit 0a7e34f)
Co-authored-by: George Gastaldi <[email protected]>
(cherry picked from commit 78906ad)
(cherry picked from commit b5dff7a)
The simple `xref:file.adoc` macros were not being processed.

(cherry picked from commit 9f48ab5)
(cherry picked from commit a3bc395)
(cherry picked from commit 366a981)
(cherry picked from commit e3f2004)
(cherry picked from commit 22a463b)
Note that I was a bit surprised that we are copying some transformed
jars in the lib/main directory.
Apparently, only jars for which we remove entries.
From my tests, the entry removal is reproducible and always produces the
exact same binary so I suppose it's good enough.

Fixes quarkusio#39130

(cherry picked from commit e5eb989)
This update brings significant changes affecting extensions utilizing a (Vert.x) TCP client. With Vert.x version 4.5.4, establishing TLS connections now mandates the use of hostname verification algorithms. This requirement impacts various components including Reactive SQL clients, Redis, RabbitMQ, MQTT, among others.

Previously, if not explicitly specified by the protocol, the verification algorithm defaulted to "". This setting essentially skipped the verification process. However, with the new version, explicit configuration is necessary. Consequently, each extension has been adjusted to utilize the most appropriate verification algorithm.

It's important to note that these modifications may potentially disrupt existing applications. In such cases, referring to the documentation of the specific extension or component is recommended for proper configuration of the hostname verification algorithm.

(cherry picked from commit ee8b09a)
… not break)

The update to Vert.x 4.5.4 necessitates adjustments in extensions leveraging the Vert.x TCP client, notably impacting reactive SQL clients. TLS connections now require explicit configuration of hostname verification algorithms.

Previously, in the absence of explicit specification by the protocol, the verification algorithm defaulted to "". Although this default remains unchanged in this commit, a MicroProfile Config limitation (eclipse/microprofile-config#446) highlights that "" is not a valid value in the Quarkus configuration. Consequently, "NONE" has been adopted as an alternative. This enables users to explicitly set the hostname verification algorithm to "NONE" to bypass the verification process.

(cherry picked from commit db68332)
This update addresses the breaking changes introduced by Vert.x 4.5.4 for MQTT and RabbitMQ integration regarding hostname verification.

To maintain backward compatibility, hostname verification is still disabled by default. However, to provide users with flexibility and security options, this version introduces connector options to activate hostname verification without using the programmatic customization.

(cherry picked from commit 6e4dee7)
cescoffier and others added 4 commits March 5, 2024 19:57
This version aligns the Vert.x and Netty versions.

(cherry picked from commit 261d756)
…ring for dev mode launch

(cherry picked from commit 5563998)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Mar 5, 2024
@gsmet gsmet self-assigned this Mar 5, 2024
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/cli Related to quarkus cli (not maven/gradle/etc.) area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/graphql area/hibernate-orm Hibernate ORM area/kafka-streams area/maven area/oidc area/persistence OBSOLETE, DO NOT USE area/reactive-messaging area/reactive-sql-clients area/redis area/rest area/security area/smallrye area/testing labels Mar 5, 2024
Copy link

quarkus-bot bot commented Mar 5, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b47f807.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

github-actions bot commented Mar 5, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Mar 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b47f807.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Maven Tests - JDK 17 Build Failures Logs Raw logs 🔍
✔️ Maven Tests - JDK 17 Windows Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Maven Tests - JDK 17 #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 967 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "21779339-ba08-4a61-9bc9-6f92feec19b0" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 967 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "21779339-ba08-4a61-9bc9-6f92feec19b0" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit 16c11df into quarkusio:3.8 Mar 6, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/cli Related to quarkus cli (not maven/gradle/etc.) area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/graphql area/hibernate-orm Hibernate ORM area/infra internal and infrastructure related issues area/kafka-streams area/maven area/oidc area/persistence OBSOLETE, DO NOT USE area/reactive-messaging area/reactive-sql-clients area/redis area/rest area/security area/smallrye area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.