Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugging to resteasy / arc interactions #39152

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 4, 2024

This relates to: #39137

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Mar 4, 2024

I see these are debug lines. Should we throw a warning or an error when we are in OP's case with @Context injection?

@geoand
Copy link
Contributor Author

geoand commented Mar 4, 2024

Theoretically RESTEasy can take care of some of them, so we should definitely not be erroring, but I could be pursuaded about a warning.

@geoand geoand force-pushed the #39137-debugging branch from 16be894 to 2ddb693 Compare March 5, 2024 07:04
Copy link

quarkus-bot bot commented Mar 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2ddb693.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.EndUserEnabledTest.baseTest - History

  • AttributesMap{data={http.client_ip=127.0.0.1, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/17.0.10), code.function=dummy, http.target=/otel/enduser, net.protocol.name=http, http.scheme=http, http.method=GET, code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.status_code=200, net.host.port=8081, http.route=/otel/enduser, http.response_content_length=0}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: AttributesMap{data={http.client_ip=127.0.0.1, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/17.0.10), code.function=dummy, http.target=/otel/enduser, net.protocol.name=http, http.scheme=http, http.method=GET, code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.status_code=200, net.host.port=8081, http.route=/otel/enduser, http.response_content_length=0}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
	at io.quarkus.it.opentelemetry.EndUserEnabledTest.evaluateAttributes...

@geoand geoand merged commit 110b6e0 into quarkusio:main Mar 5, 2024
46 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants