Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use followOutput for lra-coordinator container #39104

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

marcosgopen
Copy link
Contributor

@marcosgopen marcosgopen commented Mar 1, 2024

#39390

Adding lra-coordinator container log in microprofile-lra tck tests logs.

@quarkus-bot quarkus-bot bot added the area/lra label Mar 1, 2024
@marcosgopen
Copy link
Contributor Author

@mmusgrov

@mmusgrov
Copy link
Contributor

mmusgrov commented Mar 1, 2024

I approve of the PR but I suspect that there needs to be an associated issue.

@mmusgrov
Copy link
Contributor

mmusgrov commented Mar 6, 2024

@gsmet does @marcosgopen need a related issue in order to trigger a review?

@marcosgopen marcosgopen force-pushed the lra-coordinator-log branch from a2a61c6 to 41e2a2b Compare March 13, 2024 09:38
Copy link
Contributor

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, we need these logs to be able to effectively debug issues with the LRA extension.

Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is slf4j appropriate for this?

I don't know if we should use the logs here if it's not custom with anything else.

@mmusgrov
Copy link
Contributor

mmusgrov commented Mar 13, 2024

Is slf4j appropriate for this?

testcontainers relies on SLF4J for logging

I don't know if we should use the logs here if it's not custom with anything else.

What do you mean by "use the logs" and what does "if it's not custom ..." mean?

Can you suggest alternate functionality that will give us what we need?

@xstefank
Copy link
Member

@mmusgrov @marcosgopen together with Marco we created an integration job in lra-coordinator-quarkus that'll also test the image which is the correct fix for this problem - https://github.com/jbosstm/lra-coordinator-quarkus/blob/main/.github/workflows/build.yml#L62-L99. This PR can be closed.

@mmusgrov
Copy link
Contributor

@xstefank Thanks.

So can we go ahead and ask someone from the quarkus team to merge this PR?

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 20, 2024
Copy link

quarkus-bot bot commented Mar 20, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 41e2a2b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 7eb8479 into quarkusio:main Mar 20, 2024
17 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Mar 20, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 20, 2024
@gastaldi gastaldi linked an issue Mar 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log lra-coordinator output during microprofile-lra tck tests
4 participants