-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use followOutput for lra-coordinator container #39104
Conversation
I approve of the PR but I suspect that there needs to be an associated issue. |
@gsmet does @marcosgopen need a related issue in order to trigger a review? |
a2a61c6
to
41e2a2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR, we need these logs to be able to effectively debug issues with the LRA extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is slf4j appropriate for this?
I don't know if we should use the logs here if it's not custom with anything else.
testcontainers relies on SLF4J for logging
What do you mean by "use the logs" and what does "if it's not custom ..." mean? Can you suggest alternate functionality that will give us what we need? |
@mmusgrov @marcosgopen together with Marco we created an integration job in lra-coordinator-quarkus that'll also test the image which is the correct fix for this problem - https://github.com/jbosstm/lra-coordinator-quarkus/blob/main/.github/workflows/build.yml#L62-L99. This PR can be closed. |
@xstefank Thanks. So can we go ahead and ask someone from the quarkus team to merge this PR? |
Status for workflow
|
#39390
Adding lra-coordinator container log in microprofile-lra tck tests logs.