Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance client-side gRPC TLS configuration #39091

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

cescoffier
Copy link
Member

Previously, utilizing JKS or P12 keystores and truststores in gRPC clients was restricted due to limitations inherent in legacy gRPC-Java-based clients. However, this commit expands upon the existing configuration by introducing support for JKS and P12 in the Quarkus (Vert.x based) gRPC client.

This commit also extends the tests for both clients and servers using various certificate formats and configuration (like mTLS)

Previously, utilizing JKS or P12 keystores and truststores in gRPC clients was restricted due to limitations inherent in legacy gRPC-Java-based clients. However, this commit expands upon the existing configuration by introducing support for JKS and P12 in the Quarkus (Vert.x based) gRPC client.

This commit also extends the tests for both clients and servers using various certificate formats and configuration (like mTLS)
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation area/grpc gRPC area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/vertx labels Feb 29, 2024
Copy link

quarkus-bot bot commented Feb 29, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 44ba0d0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

github-actions bot commented Feb 29, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Feb 29, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 44ba0d0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:954)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:49)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:954)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:49)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

@cescoffier cescoffier merged commit 9b17ee9 into quarkusio:main Mar 4, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 4, 2024
@cescoffier
Copy link
Member Author

@geoand we can follow the same model for the rest client (until I introduce the registry)

@geoand
Copy link
Contributor

geoand commented Mar 4, 2024

Cool, I'll resume me PR based on this work

@cescoffier cescoffier deleted the fix-grpc-tls-handling branch March 4, 2024 19:21
@geoand
Copy link
Contributor

geoand commented Mar 5, 2024

Actually I am going to wait for the big rename to be merged so we don't mess things up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/grpc gRPC area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/vertx triage/flaky-test
Projects
Development

Successfully merging this pull request may close these issues.

3 participants