Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agroal - Only generate health checks for JDBC datasources #38959

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Agroal - Only generate health checks for JDBC datasources #38959

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f7909
Agroal - Only generate healths for active datasources
gsmet Feb 22, 2024
5ee3dc6
Drop DataSourceSupport#configuredNames()
gsmet Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../agroal/runtime/src/main/java/io/quarkus/agroal/runtime/health/DataSourceHealthCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import org.eclipse.microprofile.health.Readiness;

import io.agroal.api.AgroalDataSource;
import io.quarkus.agroal.runtime.AgroalDataSourceSupport;
import io.quarkus.agroal.runtime.DataSources;
import io.quarkus.arc.Arc;
import io.quarkus.datasource.common.runtime.DataSourceUtil;
Expand All @@ -40,10 +41,12 @@ protected void init() {
}
DataSourceSupport support = Arc.container().instance(DataSourceSupport.class)
.get();
AgroalDataSourceSupport agroalSupport = Arc.container().instance(AgroalDataSourceSupport.class)
.get();
yrodiere marked this conversation as resolved.
Show resolved Hide resolved
Set<String> names = support.getConfiguredNames();
yrodiere marked this conversation as resolved.
Show resolved Hide resolved
Set<String> excludedNames = support.getInactiveOrHealthCheckExcludedNames();
for (String name : names) {
if (excludedNames.contains(name)) {
if (excludedNames.contains(name) || !agroalSupport.entries.containsKey(name)) {
continue;
}
DataSource ds = dataSources.get().getDataSource(name);
Expand Down
Loading