Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect classes dirs from all the modules in RuntimeUpdatesProcessor #38939

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,13 @@ public TestSupport getTestSupport() {
}

@Override
public Path getClassesDir() {
//TODO: fix all these
for (DevModeContext.ModuleInfo i : context.getAllModules()) {
return Paths.get(i.getMain().getClassesPath());
public List<Path> getClassesDir() {
final List<ModuleInfo> allModules = context.getAllModules();
final List<Path> paths = new ArrayList<>(allModules.size());
for (DevModeContext.ModuleInfo i : allModules) {
paths.add(Path.of(i.getMain().getClassesPath()));
}
return null;
return paths;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

public interface HotReplacementContext {

Path getClassesDir();
List<Path> getClassesDir();

List<Path> getSourcesDir();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ public class StaticResourcesHotReplacementSetup implements HotReplacementSetup {
@Override
public void setupHotDeployment(HotReplacementContext context) {
List<Path> resources = new ArrayList<>();
addPathIfContainsStaticResources(resources, context.getClassesDir());
for (Path classesDir : context.getClassesDir()) {
addPathIfContainsStaticResources(resources, classesDir);
}
for (Path resourceDir : context.getResourcesDir()) {
addPathIfContainsStaticResources(resources, resourceDir);
}
Expand Down
Loading