Updated MongoDB/Panache parser to latest ORM parser

[FroMage]

This way, we keep it up to date, because the previous version was a pre-release of ORM 5-6.
This required some visitor changes, and in particular there's a precedence change between 'and/or' expresions who now require paren grouping.
Also, literals are not implemented correctly: only strings are supported but this was already the case: tests do not test other literals.

I could not run the tests locally, due to an outdated libssl requirement of flapdoodle. Hopefully CI will get it running.

[loicmathieu]

LGTM.

For primitive types, I'm surprised it didn't worked and nobody complained. We should add tests for them and see what happens, we can add them later.

[FroMage]

Caused by: com.mongodb.MongoWriteException: Write operation error on server localhost:37017. Write error: WriteError{code=11000, message='E11000 duplicate key error collection: test.Book index: _id_ dup key: { _id: "idiot" }', details={}}.

Not sure if this is my fault, I guess it must be. Do you have any idea how to run these tests locally on recent machines? Ones without old libssl versions?

[loicmathieu]

Tests runs on my machine so I cannot help you on that.
But to troubleshoot query issues you can enable query debugging: https://quarkus.io/guides/mongodb-panache#query-debugging

[FroMage]

I suppose it's due to something like this? flapdoodle-oss/de.flapdoodle.embed.mongo#451

[loicmathieu]

It may.

To test you can also launch locally and use testcontainers or start a MongoDB via Docker.
It may not be that simple as I think you must start it twice for all tests to works.

[FroMage]

Looks like MongoTestResource defaults to V4_4(V4_4_18), and the issue linked says that I need V6 to support the latest Ubuntu.

[loicmathieu]

You can switch locally to 6 by updating the @TestResource annotation, it allows passing the version.

[FroMage]

Yeah, except the @QuarkusTestResource is global to the entire module, so I need to update them all, or move them to a single class.

But it works, I can reproduce now.

[FroMage]

So, we have a query of the form instant < ?2 and instant is now a function in HQL, which returns the current instant.

We have several choices here, like ask people to quote those identifiers/functions if they want to use them as attributes: 'instant' < ?2, which allows us to implement these functions later.

Or we can declare we'll never use them, and turn these functions into identifiers, as was the case before.

WDYT?

[FroMage]

Actually, I see QUOTED_IDENTIFIER in the grammar, which is `instant` but I'm not sure that's really it.

[FroMage]

A quoted identifier is written in backticks. Quoting lets you use a keyword as an identifier.

select thing.interval.`from` from Thing thing
Actually, in most contexts, HQL keywords are "soft", and don’t need to be quoted. The parser is usually able to distinguish if the reserved word is being used as a keyword or as an identifier.

So it is backticks.

[loicmathieu]

I'm afraid that if we ask users to quote what was not needed before it may break existing code. If we can avoid that it will be better as it's anyway useless for MongoDB where all functions starts with $.

[FroMage]

OK, let me remove those keywords then. They do seem useful, though, given that they provide access to the current time. But whatever, not my problem ;)

[FroMage]

I did fix this bug, but tests still fail, though I suspect this may be due to mongo V6 because I don't see any query issue. So let's see what CI says.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d19c93b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[FroMage]

Well, CI says it's fine for V4. I should probably open an issue to see why the tests don't run in V6, no?

[loicmathieu]

I should probably open an issue to see why the tests don't run in V6, no?

I would say wait for someone to complain 🙈

But yes, something may have changed

[FroMage]

🤷