Add convenience methods mirroring ReflectiveClassBuildItem factory methods

[metacosm]

No description provided.

[geoand]

+1 for the new methods.

My only "worry" here is about backporting. If we do intend to backport this (and I don't see why not), then +1 for all the changes.
If we don't, then I would prefer if we only added the new methods and didn't change the build steps.

[metacosm]

I did wonder about this. Let me know and I'll revert the build steps changes.

[metacosm]

Another change that could also be made would be to deprecate the constructors, similarly to what was done for ReflectiveClassBuildItem.

[geoand]

Let's do the following: In this PR introduce only the new methods. A follow up PR can change the call sites and also deprecate the constructors. That way we'll have the flexibility to decide later on

…

On Fri, Feb 9, 2024, 08:56 Chris Laprun ***@***.***> wrote: Another change that could also be made would be to deprecate the constructors, similarly to what was done for ReflectiveClassBuildItem. — Reply to this email directly, view it on GitHub <#38679 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBMDP44SQQTA35IHHA4K73YSXCBBAVCNFSM6AAAAABC7WQKPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVGQZDCNZZHE> . You are receiving this because your review was requested.Message ID: ***@***.***>

[metacosm]

Removed the call sites changes, added javadoc, chained factory methods for better maintenance.

[geoand]

Thanks!

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9f0a591.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

• Assertion condition Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: 
Assertion condition 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)