Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce @ClientBasicAuth annotation #38603

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Introduce @ClientBasicAuth annotation #38603

merged 2 commits into from
Feb 7, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 6, 2024

This makes the use of basic authentication from
the REST client dead simple

This makes the use of basic authentication from
the REST client dead simple

Closes: quarkusio#38565
Copy link

github-actions bot commented Feb 6, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Feb 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6993e3a.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🚧
JVM Tests - JDK 21 Build Failures Logs Raw logs 🚧

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: integration-tests/virtual-threads/jms-virtual-threads 

📦 integration-tests/virtual-threads/jms-virtual-threads

io.quarkus.it.vthreads.jms.VirtualThreadTest.testAlert - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.artemis.core.deployment.DevServicesArtemisProcessor#startArtemisDevService threw an exception: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=quay.io/artemiscloud/activemq-artemis-broker:1.0.18, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@30ee13fe)
	at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1367)
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:362)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:333)
	at io.quarkus.artemis.core.deployment.DevServicesArtemisProcessor.lambda$startArtemis$1(DevServicesArtemisProcessor.java:252)
	at java.base/java.util.Optional.o...

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 core/deployment

io.quarkus.deployment.dev.FileSystemWatcherTestCase.testFileSystemWatcher - History

  • expected: not <null> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: not <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:152)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertNotNull.failNull(AssertNotNull.java:49)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:35)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:30)
	at org.junit.jupiter.api.Assertions.assertNotNull(Assertions.java:304)
	at io.quarkus.deployment.dev.FileSystemWatcherTestCase.consumeEvents(FileSystemWatcherTestCase.java:172)

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great!

Get ready for other auth methods to be requested, like digest and JWT :)

@geoand
Copy link
Contributor Author

geoand commented Feb 6, 2024

Sounds reasonable 😜

@geoand geoand merged commit 5d4e542 into quarkusio:main Feb 7, 2024
64 of 67 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 7, 2024
@geoand geoand deleted the #38565 branch February 7, 2024 06:39
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Add a dead simple way to do basic auth in REST Client
2 participants